search

Mofiqul / vscode.nvim

Neovim/Vim color scheme inspired by Dark+ and Light+ theme in Visual Studio Code
MIT License
695 stars 111 forks source link

[Regression] Vimscript options broken #122

Closed baco closed 1 year ago

baco commented 1 year ago

At commit 7d3899b7cf6c4629ae61127a9e11fe9a80cd7c55 (@daephx) the colorscheme got broken, later on, at commit 2c68d2a866879f89806be68456d9884c3adabe00 (@hewenjin) the error tried to be fixed; and between both commits options being passed in vimscript fashion stopped to work.

I have the following vimscript configuration:

let g:vscode_transparent = v:true
let g:vscode_italic_comment = v:true

that was working before the first of the commits, and didn't work anymore after de latter.

daephx commented 1 year ago

Thanks for the mention: @baco that was definitely my bad, apologize for any inconvenience. My recent PR should fix the issue.

I don't use the globals for setup anymore and thought I had checked them but I failed to check what would happen if the setup function was never called by the user or plugin manager (in my case lazy.nvim).

baco commented 1 year ago

Excellent. That patch solves de issue. I've tested it locally and can confirm it will be solved upon merge.