search

Mofiqul / vscode.nvim

Neovim/Vim color scheme inspired by Dark+ and Light+ theme in Visual Studio Code
MIT License
695 stars 111 forks source link

fix: Lualine does not respect transparency (#89) #130

Closed devadathanmb closed 1 year ago

devadathanmb commented 1 year ago

This fixes #89 where the transparency is not respected in lualine.

Rather than setting colors.bg and colors.bg2 to NONE I've used a ternary condition to set the color accordingly. This is because overriding colors.bg and colors.bg2 to NONE initially will also set the foreground colors of modes to be NONE as well wherever they are set to colors.bg or colors.bg2 which makes the text unreadable.

I've tested this version and the colors look good and readable to me in both light and dark modes. Please mention if any changes are required. Thank you.

image

2023-04-09T23:34:32,254741085+05:30

bojanmilevski commented 1 year ago

Great, thanks for this fix - much appreciated! 👍