fix: make `get_colors` return wrt to `color_overrides`

Mofiqul / vscode.nvim

Neovim/Vim color scheme inspired by Dark+ and Light+ theme in Visual Studio Code

MIT License

695 stars 111 forks source link

fix: make `get_colors` return wrt to `color_overrides` #144

Closed agronskiy closed 1 year ago

agronskiy commented 1 year ago

The issue

As a user of the theme, I want color_overrides, which I have passed during the setup, to have effect on get_colors elsewhere. Currently, they only have effect during the initialization of the theme.

The fix

Add deep table merge into get_colors.

Tests

Tested locally by importing colors in different other places of my setup.

agronskiy commented 1 year ago

Hey @Mofiqul, thanks for a great plugin. While playing with it and wanting to extend couple of other highlight groups in a consistent way (== by using local c = require("vscode.colors").get_colors()) I realized that it returned unchanged table, despite me having color_overrides in init. This fixes it.

I hope this is the desired behavior.