Mofiqul / vscode.nvim

Neovim/Vim color scheme inspired by Dark+ and Light+ theme in Visual Studio Code
MIT License
692 stars 111 forks source link

[Bug] Inconsistencies in colors #189

Open sand4rt opened 4 months ago

sand4rt commented 4 months ago

VScode:

Screenshot 2024-04-20 at 15 38 16

VScode.nvim

Screenshot 2024-04-20 at 15 40 23
johannesrld commented 4 months ago

I can see about fixing TSX Tags, however there are some issues simply due to how Treesitters JavaScript highlights are set up, for example

Highlighting type in import type would require a custom Treesitter query, this is easy but I don't really like the idea (plus Treesitter is also more accurate at highlighting the types imported by import type than VS Code, there its highlighted as a variable whilst in vscode.nvim its correctly highlighted the same colour as other types).

both the async keyword and the await keyword are captured in the highlight group @keyword.coroutine. This should probably be set to the same pinkish colour that other control flow keywords are set to like return and if but that would highlight async and await as pink, not just await, which would still be inconsistent