The plugin should set the vim terminal colors. There are many benefits, such as:
The terminal colors match the reset of neovim
Neovim guis, such as neovide, wont be stuck with default term colors
When changing style terminal will update accordingly
Plugins such as tokyonight.nvim already do this, to great effect. Potentially the colors shouldn't be based on highlight groups, as is the case right now, but rather based directly on the gui term colors.
if the second behavior is preferred (colors based on the current terminal colorschemes, as opposed to the highlight groups), I have a change all queued up for that, so just let me know and i will update the PR.
The plugin should set the vim terminal colors. There are many benefits, such as:
Plugins such as tokyonight.nvim already do this, to great effect. Potentially the colors shouldn't be based on highlight groups, as is the case right now, but rather based directly on the gui term colors.