Open wenjinnn opened 3 months ago
@wenjinnn, @xyven1 - Keeping it true
as default is what I would prefer. We need to add it to the README.
Hey, I can also fix it as I mentioned in the PR by using the colors defined in the terminal extensions, which will make the colors brighter again.
Since I think (correct me if I'm wrong) the main goal of this plugin is to provide a color scheme which replicates vscode colors as close as possible, using the colors defined in the terminal extensions would better accomplish that task. I'm happy to make that fix, add some documentation to the README and pr that @Mofiqul.
Hi, thanks for reply, I just read the PR comment. Personally, I prefer neovim internal terminals to keep the same color as the normal terminal, cuz I customized terminal color like vscode by myself. but other people might like this feature, so I think nothing wrong about this, just add some documentation will be nice.
Hey, I can also fix it as I mentioned in the PR by using the colors defined in the terminal extensions, which will make the colors brighter again.
Since I think (correct me if I'm wrong) the main goal of this plugin is to provide a color scheme which replicates vscode colors as close as possible, using the colors defined in the terminal extensions would better accomplish that task. I'm happy to make that fix, add some documentation to the README and pr that @Mofiqul.
Let's go with as it is by mentioning in Readme
Hi there. This commit add a
after:
I think we should consider about this, Is it need to be
terminal_color = true
as a default config value, before I upgrade to this commit, my terminal looks like:true
as default? and may be add some doc about this new config value, because it took me some time to figure out that is was this config caused these effects.