search

Mofiqul / vscode.nvim

Neovim/Vim color scheme inspired by Dark+ and Light+ theme in Visual Studio Code
MIT License
695 stars 112 forks source link

fix: correct markdown inline code highlight #65

Closed TeamTamoad closed 2 years ago

TeamTamoad commented 2 years ago

This PR fixes https://github.com/Mofiqul/vscode.nvim/issues/37

image

David-Else commented 2 years ago

Afraid this does not seem to be working:

Screenshot from 2022-06-27 13-18-25

Are you using the latest markdown parser(s)? https://github.com/nvim-treesitter/nvim-treesitter/issues/2293#issuecomment-1166574954

rockyzhang24 commented 2 years ago

@David-Else Exactly. We just need to change TSLiteral to TSLiteral = { c.vscOrange, 'none', nil }, to fix this issue.

Hi @TeamTamoad , can you adjust this?

TeamTamoad commented 2 years ago

Are you using the latest markdown parser(s)? https://github.com/nvim-treesitter/nvim-treesitter/issues/2293#issuecomment-1166574954

I didn't use the latest markdown parser. I use LunarVim and it looks like the maintainers haven't update the nvim-treesitter to the latest version. Thank you for pointing this breaking changes out.

We just need to change TSLiteral to TSLiteral = { c.vscOrange, 'none', nil }, to fix this issue.

The reason that I didn't do this in the first place is that I afraid that it could unintentionally change the highlight color of other languages.

To fix this issue for the latest version of the markdown parser, we can just add this markdown_inlineTSLiteral = { c.vscOrange, 'none', nil }

I'll make a PR to fix this