Mofiqul / vscode.nvim

Neovim/Vim color scheme inspired by Dark+ and Light+ theme in Visual Studio Code
MIT License
712 stars 114 forks source link

fix: set underline for indent-blankline ContextStart #96

Closed daephx closed 1 year ago

daephx commented 1 year ago

I think that the highlight group IndentBlanklineCurrentContext should either be removed in order to use the plugins default settings, or should be changed to use an underline that matches the current context color set by #50.

This PR currently does the latter and preserves IndentBlanklineCurrentContext but sets underline = true and switches guifg with guisp for vscContextCurrent.

With indent_blankline.setup({ show_current_context_start = true }), vscode.nvim sets a foreground color for IndentBlanlineContextStart, resulting in treesitter highlights being overridden with colors.vscContextCurrent.

WindowsTerminal_pXJs6kFvuF

Using tokyonight as a comparison: IndentBlanklineCurrentContext isn't set at all, implying that the default settings from indent-blankline.nvim are used.

WindowsTerminal_IG5yT7XuOK

daephx commented 1 year ago

Previous screenshots were in Windows Terminal which doesn't handle underline colors very well from what I can tell.

Here are some examples within kitty terminal.

With highlight vscContextStart:

mstsc_iY2ZvsxmMi

With IndentBlanklineContextStart removed, highlight gets set to: IndentBlanklineContextStart xxx cterm=underline gui=underline guisp=#c586c0

mstsc_FWg47g5qTK