zbx_service_discovery.sh use sed

[TEH30P]

Hi.

In script /usr/local/bin/zbx_service_discovery.sh why don't you use systemctl filter insted of grep and sed insted of awk (and also grep)?

# sed with BRE
systemctl list-unit-files --type service --state enabled --state generated | sed -e '1d; /^$/Q; s/[[:space:]]*enabled$//; t; s/[[:space:]]*generated$//'
# or little shorter with ERE
systemctl list-unit-files --type service --state enabled --state generated | sed -re '1d; /^$/Q; s/\s+(enabled|generated)$//'

... vs your

systemctl list-unit-files | grep -E '\.service\s+(generated|enabled)' | awk -F'.service ' '{print $1}'

[MogiePete]

That is the decision that was made and it works.

Thanks for the input.