search

Moguri / blend2bam

A CLI tool to convert Blender blend files to Panda3D BAM files
MIT License
68 stars 18 forks source link

--no-srgb does not convert vertex colors #59

Open BartGunshot opened 3 years ago

BartGunshot commented 3 years ago

The --no-srgb flag should probably convert vertex colors to rgb as it does textures. This might need to be handled upstream in blendergltf.

rdb commented 2 years ago

For clarity…

Note that vertex colours are always linear, even when stored as bytes. panda3d-gltf just passes through the vertex colours unchanged. Also see KhronosGroup/glTF#1638. This is partially because GPU drivers do not actually support sRGB vertex colours, unfortunately.

What you're asking for is a feature to convert them to sRGB encoding when using --no-srgb. It seems potentially useful, but there should be an opt-out for people who use vertex colours to store non-colour data.

It might also be interesting to consider something upstream in Panda3D for this, to automatically convert vertex colours in the munger as needed, but this would need to be coordinated with other colour space work in Panda3D.