search

Moguri / panda3d-gltf

glTF utilities for Panda3D
BSD 3-Clause "New" or "Revised" License
82 stars 19 forks source link

Disabling hidden behavior of shimming loader.loadModel in favor of explicit call. #126

Closed csevier closed 1 year ago

csevier commented 1 year ago

Its a great tool but I find it confusing that if I pip install panda3d-gltf, unannounced to the user it changes the behavior of their model loads silently. This is against python ethos for explicitness, but practically it can be confusing and jarring. Perhaps this isnt the right place for this, maybe a change to loader behavior to specify the importer youd like to use explicitly in panda itself. Perhaps even adding a method dynamically to loader. Unsure, its just surprising behavior to users.

Moguri commented 1 year ago

The Python file loader (the mechanism that his package uses to register a new loader with Panda), is an advertised feature and one of the primary reasons users download the package. So, I would hardly call it "hidden", "unannounced", or "silent".

To disable automatically registering file loaders from Python packages, I believe you can set the loader-support-entry-points to f or 0.

csevier commented 1 year ago

I suppose that's up to how you interpret the word "seamless". I certainly did not interpret it that way. Sorry for the confusion! Thanks for bringing my attention to the override capability.

csevier commented 1 year ago

Can override the behavior and is explicitly desired behavior by authors and others.