search

Moguri / panda3d-gltf

glTF utilities for Panda3D
BSD 3-Clause "New" or "Revised" License
81 stars 19 forks source link

Use new Panda3D 1.10.8 M_emission mode #88

Closed rdb closed 3 years ago

rdb commented 3 years ago

Using M_add turns out to be a little awkward, because M_add doesn't multiply with the emission colour. simplepbr needs the fallback texture to have (1, 1, 1, 1) colour, but that results in fully whiting out the model without simplepbr.

Therefore I added a new M_emission slot to 1.10.8, a specific slot that's disabled in the FFP (its specific behaviour can't be implemented easily using texture combiners, I'm afraid). This makes use of that slot.

Thoughts on this approach?

Moguri commented 3 years ago

This sounds good to me and we are now on 1.10.9 release of Panda, so I think requiring 1.10.8+ is fine.