search

MohGovIL / hamagen-react-native

Israel's Ministry of Health's COVID-19 Exposure Prevention App
https://health.gov.il/
MIT License
509 stars 153 forks source link

wrong overlapping event #191

Open RamLavi opened 4 years ago

RamLavi commented 4 years ago

I'm using the app on android OS, recently got an overlap event with a varified COVID19 patient. When I cross-checked with ministry of health's most updated report AND after rechecking with your PointsUtc.json file, the there is no overlapping.

Specifically, the app claims there has been a verified COVID19 patient in "מגה בעיר", רחוב אבן גבירול 30, תל אביב - יפו at the time of 31.03.20 at around 11:59 but there hasn't been one according to your db ( the only occurrence in this location is at 2.4.20): 

{"type":"Feature","id":382637,"geometry":{"type":"Point","coordinates":[34.7819995,32.0749569000001]},"properties":{"OBJECTID":14797,"ID":null,"Name":"","Place":"\"מגה בעיר\" אבן גבירול 30 תל אביב - תל אביב - יפו","Date":1586510303000,"types":"G_Poi","Comments":null,"POINT_X":32.0749569000001,"POINT_Y":34.7819995,"fromTime":1585832400000,"toTime":1585833000000,"sourceOID":1,"flight":null,"flightFrom":null,"flightArrival":null,"stayTimes":"14:00 - 14:10","fromTime_utc":1585825200000,"toTime_utc":1585825800000,"Key_Field":14797}}

also attached 1) jpg of event reported according to your app. WhatsApp Image 2020-04-12 at 09 29 45

RamLavi commented 4 years ago

@greenyossi, can anybody take a look at this issue?

RamLavi commented 4 years ago

@dotansimha @yoav85 @MaxToyberman can you take a look at this issue? I think false-positives (and maybe undiscovered false-negatives?) are not something that this app should have the luxury of having.

dotansimha commented 4 years ago

@RamLavi I'm not part of this project officially, and honestly, as an open-source developer, I'm not excited or keen to work on this project at all.

This project is not maintained as a real open-source. It seems like the MOH developers has their own private and plan agenda, and they just manage the source code on GitHub.

The roadmap is not clear and not public, CI fails, there are PRs that has been ignored by the maintainers, and in general it seems like a poorly maintained open-source.

You can take a look at the list of PRs for example. And the list of commits is messy, open-source project shouldn't have commits called fixes or some more fixes or updated.

The effort of sharing the developers community is worth it, but it seems like the MOH doesn't understand it so far, and they choose to develop it internally, and just share the source code.

As @urigo said (and was ignored) in https://github.com/MohGovIL/hamagen-react-native/issues/141 - we, for example, have a team of open-source experts that can help for free, but we don't know how, and we really don't want our PR to be done like this one: https://github.com/MohGovIL/hamagen-react-native/pull/92#issuecomment-603408386 (this could be avoided, with a public roadmap, and a list of issues the community can help you with, and sharing what you team works on now)

@AlmaMOH @MiriShalev @greenyossi @OrenMOH