search

MohGovIL / hamagen-react-native

Israel's Ministry of Health's COVID-19 Exposure Prevention App
https://health.gov.il/
MIT License
509 stars 153 forks source link

Push react-native-splash-screen change upstream & look for other library #198

Open emanuelb opened 4 years ago

emanuelb commented 4 years ago

fork of react-native-splash-screen library by user @greenyossi that located in https://github.com/greenyossi/react-native-splash-screen is used in package.json

https://github.com/MohGovIL/hamagen-react-native/blob/09293b88d6168be8c521529dd7f97a1f6ee85887/package.json#L51

which contain 1 change:

This branch is 1 commit ahead of ExodusMovement:master.

at commit: "Update RNSplashScreen.m" "add fade to hide on iOS" https://github.com/greenyossi/react-native-splash-screen/commit/cf4cabb8e5269a18a764d8bfc7e66c737a0732ae

push the change upstream, the current upstream is: https://github.com/ExodusMovement/react-native-splash-screen which looks unmaintained and doesn't have issues tab to report issues (only PRs which was never used) The upstream of the above project is (the package react-native-splash-screen in yarn registry is pointing to this repo https://yarnpkg.com/package/react-native-splash-screen) https://github.com/crazycodeboy/react-native-splash-screen

looks like it's poorly maintained, see: https://github.com/crazycodeboy/react-native-splash-screen/issues/468

which suggest to use the alternative library react-native-bootsplash (looks like it's maintained) at: https://github.com/zoontek/react-native-bootsplash that is published to yarn registry https://yarnpkg.com/package/react-native-bootsplash

it doesn't look like there is a maintained fork of react-native-splash-screen library, at least not one that is published in yarn registry as they are all old (last update 1 year ago..) https://yarnpkg.com/?q=react-native-splash-screen

emanuelb commented 4 years ago

it's also possible to implement splash screen without using additional/external libraries/dependencies, see: https://whatdidilearn.info/2019/01/13/how-to-implement-a-splash-screen-in-react-native.html

kaplanlior commented 4 years ago

Repo is now cloned to under MOH account and also asked upstream to merge the changes at ExodusMovement/react-native-splash-screen#4 . If they would, we could remove that repo.