kaplanlior
commented
4 years ago Thanks @rr9845 for the whatup link. I'm happy people play with the code. We'll make sure to publish better instructions.
Closed rr9845 closed 4 years ago
kaplanlior
commented
4 years ago Thanks @rr9845 for the whatup link. I'm happy people play with the code. We'll make sure to publish better instructions.
kaplanlior
commented
4 years ago Please use npm install --ignore-scripts for Linux, as it works around the existing postinstall script meant mainly for mac (see #244 ).
kaplanlior
commented
4 years ago Duplicate of #204
emanuelb
commented
4 years ago Many issues in above instructions/expectation:
What is the expected checksum md5 and sha512 for the builds .
Impossible, each APK will have different checksum due to different keys used for signing (different keystore files/params are supplied)
what is possible is to have list of checksums for files uploaded to stores: #270 (which then can be check with repro-build to ensure matched code exists in github)
2.1 - no mention of installing java (last I checked for older v1 versions apk, they built using java8)
2.2 - missing --no-install-recommends argument for apt-get install
sudo apt-get install git npm sudo apt-get install android-sdk
Add --no-install-recommends argument (install less not-needed deps)
2.3 not combined installed commands, missing apt-get update
it's better to install all required deps in 1 command & run apt-get update before it.
see #279 for more info
npm install
Better to use:
npm ci or npm install --production
Currently it won't work due to some issues like #173 , #254 , #265
use npm install only if you planning to run tests as well npm test / yarn jest
yarn can be used instead of npm.
apk build will fail without it.
See issue #243 which contain files that use debian/alpine distros.
consider adding --ignore-optional for npm install
using --ignore-scripts will require running npx jetify later, issue: #242
Vagrantfile
can be used to compile and then run the android app as well: see issue: #266
kaplanlior
commented
4 years ago You're welcome to review and comment on the draft at https://github.com/MohGovIL/hamagen-react-native/issues/204#issuecomment-666427678
We closed this issue as a duplicate so all comments would be in one place. Thanks.
emanuelb
commented
4 years ago I did, see: https://github.com/MohGovIL/hamagen-react-native/issues/204#issuecomment-671765098 this comment was mostly written before this issue was closed (there more related issues to building/build-instructions, which I will open later) and the content at this comment is mostly relevant (almost all items apply) to the draft/discussion at issue #204
I'm arriving here after reading https://whatsup.org.il/forum/64312, please publish a building.md (or an equivilant for that) on how to build to the project from scratch.
This is also a variant of #204
building.md should show :
For each stable OS (Win10, Arch , Debian 10, Centos,Docker mac, etc) what packages / programs MUST be installed before building.
It should express each step needed to build the application.
What actions and options should be selected to build the program.
What is the expected checksum md5 and sha512 for the builds .
For each step what is the expected result.
Something like:
For debian 11 install npm and git.
example repository configuration (/etc/apt/sources.list):
The comment here is for Debian 11 , it will install git and npm
command :
sudo apt-get install git npmexpected result:
clone the repo
git clone https://github.com/MohGovIL/hamagen-react-nativeresult: `
enter the repo:
run npm install in the folder, his will install dependencies which are refernced in file
result:
install android_sdk
sudo apt-get install android-sdkresult:set envoirment varibale ANDROID_SDK_ROOT to path of your android sdk
export ANDROID_SDK_ROOT= /usr/lib/android-sdkfrom hamagen-react-native/android exexcute ./gradlew (not the standard gradle ! )
result: