MohGovIL / hamagen-react-native

Israel's Ministry of Health's COVID-19 Exposure Prevention App
https://health.gov.il/
MIT License
508 stars 153 forks source link

Bundle google_maps_api_key into repo #277

Open emanuelb opened 4 years ago

emanuelb commented 4 years ago

Currently compiling android app require adding:

<?xml version="1.0" encoding="utf-8"?>
<resources>
    <string name="google_maps_api_key">GOOGLE_MAPS_API_KEY</string>
</resources>

to android/app/src/main/res/values/secrets.xml file. But this won't help with reproducible-builds (which need the exact GOOGLE_MAPS_API_KEY value used for that version) and only make the build process require more steps.

As the AndroidManifest.xml require google_maps_api_key value https://github.com/MohGovIL/hamagen-react-native/blob/0874f1c052b096e626b5f13446276d2c87aca6e7/android/app/src/main/AndroidManifest.xml#L75-L78

I suggest to add it to the repo, in order to avoid needing to do the process below:

obtaining key from APK v2.2.6 below:

podman run --rm -ti docker.io/debian:sid
apt-get update; apt-get install --yes --no-install-recommends wget apktool;
wget https://github.com/MohGovIL/hamagen-react-native/releases/download/v2.2.6/hamagen-v2.2.6.apk
apktool d -s hamagen-v2.2.6.apk 
cat hamagen-v2.2.6/res/values/strings.xml | grep maps

which result in:

<string name="google_maps_api_key">AIzaSyBJzZETb4fOiGRokZFvm0c-ZvaSnz0Hia4</string>