MohGovIL / hamagen-react-native

Israel's Ministry of Health's COVID-19 Exposure Prevention App
https://health.gov.il/
MIT License
509 stars 153 forks source link

Bug: OS large font settings prevents installation for certain languages, on some devices #70

Open golosovsky opened 4 years ago

golosovsky commented 4 years ago

mi a2

The 'APPROVE' button is missing during {Eng / Rus} installation on Xiaomi Mi A2. with large font OS settting on. The issue probably occurs due to disabled scrolling in installation phase.

Impact: the issue prevents, for example, {Eng / Rus} speakers with large font setting on, from installing the app, if they don't switch to Hebrew.

If enabling scrolling on this specific dialog isn't an option (as suggested by @YOEL311 – "you can't do ScrollView in a Model") a possible solution might be to override the OS font size settings and to pick the size depending on the actual screen size -- so that the entire dialogue, including the 'APPROVE' button will fit 100% of the times, independent of OS / font settings / device.

YOEL311 commented 4 years ago

This happens because you can't do ScrollView in a Model I tried it

https://github.com/MohGovIL/hamagen-react-native/blob/3c6695c2b2cab3bb00a1e1b2b39a5fab18fb2f93/src/components/common/ForceTerms.tsx#L35

golosovsky commented 4 years ago

@YOEL311 Yeah, I understand. What might be an appropriate solution? Currently this prevents some users from initializing the app; that defeats the entire purpose of the app.

AdamGold commented 4 years ago

@YOEL311 Actually you can propagate swipes to a ScrollView within a Modal. Would you like me to submit a PR?

golosovsky commented 4 years ago

A possible solution might be to override the OS font size settings and to pick the size depending on the actual screen size -- so that the entire dialogue, including the 'APPROVE' button will fit 100% of the times, independent of OS / font settings / device. What do you guys think? @AdamGold @YOEL311

YOEL311 commented 4 years ago

@AdamGold right His PR is excellent

YOEL311 commented 4 years ago

I think it's worth adding persistentScrollbar={true}

  <ScrollView persistentScrollbar={true} style={{ flex: 0.6, paddingHorizontal: 40 }}>

This way they can see that there is a possibility to scroll If you do not need the scroll you will not see it