search

Mohamed-512 / Extra-Streamlit-Components

An all in one place, to find complex or just not available components by default on streamlit.
Apache License 2.0
466 stars 59 forks source link

Caching and version updates #51

Closed mkhorasani closed 1 year ago

mkhorasani commented 1 year ago
  1. Updated st.cache to st.cache_resource
  2. Update Streamlit version to >= 1.11.0
CHerSun commented 1 year ago

I'm pretty sure cache_resource was introduced in 1.19 or 1.18:

image

CHerSun commented 1 year ago

Found it in changelogs. In 1.18.0: image

So you should bump version to that.

mkhorasani commented 1 year ago

I'm pretty sure cache_resource was introduced in 1.19 or 1.18:

image

Great catch! Fixed it to >= 1.18.0.

JamesFinlayson2 commented 1 year ago

Does this not suffer from mutation issues as allow_output_mutation is no longer supported?

mkhorasani commented 1 year ago

Does this not suffer from mutation issues as allow_output_mutation is no longer supported?

Correct, that is why I have removed that argument from the PR.