MohamedBeydoun / atlas

An express-typescript code generator
Apache License 2.0
6 stars 0 forks source link

Useless .keep files #17

Open AsFal opened 4 years ago

AsFal commented 4 years ago

All folders in the generated project have a useless .keep file.

MohamedBeydoun commented 4 years ago

".keep"s are added for github. Empty folders cannot be pushed to github. Would adding a "git-keep" flag when creating the app solve the issue?

AsFal commented 4 years ago

General

I would want to remove the Atlas GitHub coupling altogether. I would suggest the following file structure for the boilerplate generated by the atlas create command. This method would also allow the cli user to quickly get an idea of the generated code to determine if he likes the chosen architecture.

Updated Initial Boilerplate

Modifications from previous file structure

MohamedBeydoun commented 4 years ago

only generating folders when needed would mean that the user can create a differently named folder for the same use case. I would rather create the folder to let them know where to put their interfaces/utilities. Also, why would app and server be outside of our src directory?

MohamedBeydoun commented 4 years ago

.keep files will be replaced with sample resource files

MohamedBeydoun commented 4 years ago

.keeps have been removed. Sample files will come later.