MohamedDanis / opnhub

https://opnhub.vercel.app
15 stars 11 forks source link

No Language indication in repository card #23

Closed MohamedDanis closed 1 month ago

MohamedDanis commented 1 month ago

Description: After selecting multiple languages, the repositories are shown below randomly.But I cannot identify the languages of each repo without going inside the github website

Steps to Reproduce: Go to the search bar. Enter language name and select multiple languages. The repositories are shown in random

Expected Behavior: Each repository card need a language indication in the card

Actual Behavior: There is no indication of which language used in the repo

Screen Shot: Screenshot 2024-10-03 161753

Suggested Fix: Add a language indication in the card

Environment: Browser: Chrome 117 Operating System: Windows 11

imkeanserna commented 1 month ago

@MohamedDanis i would love to work on this, can you please assign it to me?

MohamedDanis commented 1 month ago

Thank you for your interest. I want to ensure that everyone gets a fair chance to contribute during Hacktoberfest. If no one is assigned to this issue in the next few days, I will gladly assign it to you. Please stay tuned, and don't worry—your contributions are valued! @imkurosaki

imkeanserna commented 1 month ago

@MohamedDanis, that's a great idea! We can switch it to an icon since many repositories use multiple languages. However, the downside is that frequent requests to the GitHub API may hit the rate limit like this: image image

MohamedDanis commented 1 month ago

the rate limit issue is the next feature/issue need to be implemented,I'm working on it.rn, focus on the design @imkurosaki

LeninKhangjrakpam commented 1 month ago

Hey @MohamedDanis , sorry about the PR without assigning. Do you still want to assign this issue to me?

MohamedDanis commented 1 month ago

Yeah I can do that, before that we need to discuss about the design

LeninKhangjrakpam commented 1 month ago

@MohamedDanis , could you take a look at this? Any feedback or suggestions for improvement would be appreciated. I’m currently working for a single language per card (due to rate limitation issues for getting multiple language used in a repo).

image

MohamedDanis commented 1 month ago

it's ok,but the color is too vibrant,try the tag background color

LeninKhangjrakpam commented 1 month ago

is this better ? image

MohamedDanis commented 1 month ago

try using the colors of text inside the tag

LeninKhangjrakpam commented 1 month ago

@MohamedDanis image

MohamedDanis commented 1 month ago

It's ok, make a pr and I will review it @LeninKhangjrakpam

MohamedDanis commented 1 month ago

any updates @LeninKhangjrakpam