search

MohamedRejeb / Calf

Calf is a library that allows you to easily create adaptive UIs and access platform specific APIs with Compose Multiplatform (Adaptive UI, File Picker, WebView, Permissions...).
https://mohamedrejeb.github.io/Calf/
Apache License 2.0
865 stars 37 forks source link

Separate Web-View from UI Package #46

Closed Shahriyar13 closed 2 months ago

Shahriyar13 commented 9 months ago

Please review it, I am not sure about adding CocoaPods/Regular Framework dependency is because of WebView or not, If it's true, the documents should be change too.

Because of JavaFX usage in WebView module, and adding JavaFX and coroutines only because of WebView, I separated WebView to another package:

api("com.mohamedrejeb.calf:calf-ui-webview:0.3.0")

com.sun.javafx.application.PlatformImpl startup
WARNING: Unsupported JavaFX configuration: classes were loaded from 'unnamed module @82702de'
Exception in thread "JavaFX Application Thread @coroutine#1" java.lang.IllegalArgumentException: Not on Main thread, current thread is: Thread[#24,JavaFX Application Thread @coroutine#1,5,system]
Shahriyar13 commented 9 months ago

If you agree for next release:

Breaking Changes:

WebView removed from UI:

// For Adaptive WebView components
api("com.mohamedrejeb.calf:calf-ui-webview:0.3.0")
MohamedRejeb commented 2 months ago

Thanks for your contribution. Sorry for taking too much to accept this.