Restore RichTextStyle with Undo/Redo in Compose Desktop

MohamedRejeb / compose-rich-editor

A Rich text editor library for both Jetpack Compose and Compose Multiplatform, fully customizable, supports HTML and Markdown.

Apache License 2.0

1.15k stars 73 forks source link

Open MohamedRejeb opened 1 year ago

MohamedRejeb commented 1 year ago

Now if we use undo/redo in compose desktop the restored text doesn't have the right style

v1rus-dev commented 1 year ago

Hi, can you add functions to RichEditState for Undo/Redo?

MohamedRejeb commented 1 year ago

It's on the scope, I'll try to add it before 1.0.0

kannansrepo commented 7 months ago

Hi @MohamedRejeb is the undo functionality added now?

MohamedRejeb commented 7 months ago

Hi, not yet, but it's on top of my list.

kannansrepo commented 7 months ago

Thanks! sorry to bug you, Is there any work around for this until you introduce it? do you have anything in your mind, I can work on it.

MohamedRejeb commented 7 months ago

These should be the steps needed to implement this feature.

Two stacks for undo and redo.
Two public methods undo() and redo() in RichTextState class.
When the state is changed, we need to add the old state to the undo stack (This is challenging because we need to ignore some changes, such as selection changes...).
Add key event listener and call undo and redo methods when command z and command shift z are pressed.

ln-12 commented 7 months ago

For now it seems to be Android only but eventually this comes to the multiplatform implementation as well and/or you can copy the implementation.

gogopro-dev commented 5 months ago

bump, BasicTextField2 has been released to the multiplatform