search

MohamedYasser97 / lyricurator

A bot that scrapes azlyrics.com for lyrics and other data with additional tweeting functionality
https://twitter.com/lyricurator
The Unlicense
5 stars 8 forks source link

Refactor into modules #10

Open MohamedYasser97 opened 2 years ago

MohamedYasser97 commented 2 years ago

It would be nice if someone could refactor this project into modules so it can just act as a CLI lyrics tool with the Twitter feature just as an added feature

jbarbaran commented 2 years ago

Hi Mohamed,

Related to this task, you would like that lyricurator would import a module (let's say TwitterLyricsProxy) therefore it is imported by lyricurator, am I right?

MohamedYasser97 commented 2 years ago

@jbarbaran What I had in mind was to organize the code more than just 2 util files..maybe a module or class that only deals with network requests and another that deals with lyrics parsing and processing and another only for twitter configuration and tweeting and so on. I still don't have an exact idea for it but it should be something similar to this.

jbarbaran commented 2 years ago

Thank you @MohamedYasser97 , I'll give it a try, and we can evolve the solution as we go on.

Thanks!

geek0ps commented 2 years ago

I would also love to give this a try but I will be needing more context as to what you really want to be done.

MohamedYasser97 commented 2 years ago

@AsyncDeveloper245 why not we give @jbarbaran a chance 😅 maybe he's already working on it. There is however a bug I discovered and opening an issue with it now in case you're interested

geek0ps commented 2 years ago

Yes, @MohamedYasser97 sure😄. I will check it right away!

jbarbaran commented 2 years ago

Thank you @MohamedYasser97 and @AsyncDeveloper245 , I've been a bit busy at work at the of the week, but I'm working on this issue as well. Thank you!