Revert "config-loader.js guard for in loop"

MohammadYounes / rtlcss

Framework for transforming Cascading Style Sheets (CSS) from Left-To-Right (LTR) to Right-To-Left (RTL)

https://rtlcss.com

MIT License

1.68k stars 129 forks source link

Closed XhmikosR closed 3 years ago

XhmikosR commented 3 years ago

This reverts commit dfa4a3282d316dd9607b9a42b358144e4cc8cd31.

I did this quickly and I don't think it's the proper fix. Let's revert this until we have a proper fix

MohammadYounes commented 3 years ago

fixed in 2affb226cbbf662e2476e85381eea84353f17a74.

XhmikosR commented 3 years ago

Thanks! Are you sure your fix is correct, though? Shouldn't the new check cover both conditions?

MohammadYounes commented 3 years ago

@XhmikosR The first check is to ensure only source own properties are copied, second check to prevent adding properties to destination __proto__ .