search

Mohammed-Faizzzz / pe

0 stars 0 forks source link

Edit Command does not allow realistic phone numbers #16

Open Mohammed-Faizzzz opened 10 months ago

Mohammed-Faizzzz commented 10 months ago

In the following command: edit 1 p/+6597221468

The phone number is a valid Singaporean Phone Number, but is not accepted, and an error is thrown.

nus-se-bot commented 9 months ago

Team's Response

The reasoning is provided in the other report. Here I would like to elaborate on why I decide lower the severity.

I do not think that it will cause much inconvenience to the users given that the context of our is already set in Singapore, it is unlikely for users to add +65 when entering phone number.

As people will generally opt for the easier method, which is directly entering 8 digits, people are even less likely to type out the country code, which render this even scenario less common.

Even if this scenario really did happen, it would almost happen for one time as the user would now be aware of this constraint.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Realistic Phone Numbers not accepted

In the following command: add n/Ryan Ong p/+6597221468 e/ryanong@gmail.com t/tall t/skinny t/wears spectacles pr/medium i/car insurance

The phone number is a valid Singaporean Phone Number, but is not accepted, and an error is thrown.

[original: nus-cs2103-AY2324S1/pe-interim#5087] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thanks for pointing this out.

First of all, we have specified phone number to be 8 digit Singaporean number. The reason why I did not allow the +65 to be inputted in the first place is because this information is somewhat redundant given the context is already set in Singapore. I do not see the need to explicitly state the country code for the phone number.

image.png

I believe the goal of the product is increase the productivity of our users, and to me, there is no need to enter +65 when user can just enter the phone number directly and it is also definitely faster this way. Thus, I think it is very rare for users to enter actually put in the full phone number along with the country code.

However, I do agree that increasing the flexibility of the input is good to have, but at a lower priority level compared to other features implementation. This change does not provide much value to current product and we should put our effort on higher priority matters first, thus I declare it as not in scope.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]