search

Mohelm97 / screenrecorder

A simple screen recorder app designed for elementary OS.
GNU General Public License v3.0
59 stars 15 forks source link

Integrating Screenkey for key capturing #27

Open peteruithoven opened 5 years ago

peteruithoven commented 5 years ago

Fixing: #26

peteruithoven commented 5 years ago

@Mohelm97 what do you think about this idea? Would it be an issue to include screenkey as a default dependency?

Mohelm97 commented 5 years ago

@peteruithoven Well, that was soo fast :D Thanks a lot mate, I think it's a good idea until we write something else, I will test it tomorrow and see how it looks like <3

Mohelm97 commented 5 years ago

@peteruithoven It's awesome, and I don't know why I need to unset XMODIFIERS to make it works, see this issue https://github.com/wavexx/screenkey/issues/36, and what do you think about showing only modifier sequences?

peteruithoven commented 5 years ago

I still need to do that as well, I totally forgot about that issue I just opened a new question on stack exchange: https://elementaryos.stackexchange.com/questions/18810/running-screenkey-on-elementary-os

One of the biggest risks in integrating this into Screen Recorder is that we might get a lot of screenkey related issues reported to us. Like this Cannot initialize input method issue.

peteruithoven commented 5 years ago

I've reopened and updated this old issue of mine: https://github.com/elementary/gala/issues/27

peteruithoven commented 5 years ago

I should try overriding environment variables for screenkey by using SubprocessLauncher.

peteruithoven commented 5 years ago

Temporary workaround:

unset XMODIFIERS
unset GTK_IM_MODULES
unset QT_IM_MODULES
com.github.mohelm97.screenrecorder
peteruithoven commented 5 years ago

While reading other issues this comment from @ryonakano caught my attention:

elementary OS uses IBus out of the box, but it does not start IBus daemon.

https://github.com/elementary/switchboard-plug-keyboard/issues/231#issuecomment-517914033

Looks like screenkey works just file after starting: ibus-daemon -drx.

Mohelm97 commented 5 years ago

@peteruithoven So instead of unsetting stuff, we can run the ibus daemon? cool I'm working now (offline) on an advance options screen so we can add the screenkey, changing the background, circling the cursor, and the gif encoding in it, so get ready :D

ryonakano commented 5 years ago

I personally think running IBus Daemon should be handled by the OS itself: the OS should start IBus Daemon automatically even in any language. As far as I confirmed on Ubuntu 18.04 (en_US) Ubuntu does this.