search

Mohelm97 / screenrecorder

A simple screen recorder app designed for elementary OS.
GNU General Public License v3.0
59 stars 15 forks source link

Improve build #44

Open NathanBnm opened 5 years ago

NathanBnm commented 5 years ago

I improved a little the way your app is build with meson.

I split the meson.build files within the different folders for more clarity. I also simplified the post_install.py script and added the .editorconfig with elementary recommended parameters.

Finally I moved the gresources to a better location in icons/symbolic.

This PR is ready for review

ryonakano commented 5 years ago

The CI complains about the permission error of the postinst script:

meson.build:42:6: ERROR:  Script or command 'meson/post_install.py' not found or not executable

I guess you need to chmod the permission of meson/post_install.py.

NathanBnm commented 5 years ago

You're absolutely right, it happens sometimes. I'm going to fix this during the day !