search

Mohid-Water-Modelling-System / Mohid

Official MOHID Water Modelling System repository
http://www.mohid.com
70 stars 58 forks source link

Convert to hdf5 with fproj and gfortran #55

Closed rosatrancoso closed 2 years ago

rosatrancoso commented 2 years ago

These changes were only tested for:

guillaume7 commented 2 years ago

Hi Rosa,

I find it cool that you use a docker container to build the mohidwater code. For me it's all right, you may carry on ;)

Long time no seeing from you. How are you doing?

Cheers,

Guillaume

rosatrancoso commented 2 years ago

Hi! Wouldn't "use fproj" cause this files to look for fproj.F90 in the working directory and, since we only have proj4.F90, throw an error?

Hi @dsilvapiedra Apologies I just saw this now .

You are right, use fproj will search for a module called fproj, which is now installed as an external library https://gitlab.com/likeno/fortran-proj/ , like netcdf or hdf5 are.

With this change, we no longer need the file proj4.f90. This is a legacy thing. The file proj4.f90 is actually a copy of the deprecated fortran wrapper for proj library (libproj4f ). It should have been an external library but back in the day, I didn't know how to compile dlls in Windows (I still don't know!) so I included it in the code.

It would be wonderful if someone could compile this Windows and we could have a cleaner state of the code.

See Linux compiling instructions in the Dockerfiles provided here, for example, with dynamic linking: https://github.com/rosatrancoso/docker-mohid/blob/master/Dockerfile.dynamic#L50:L57

Note: You don't have to use docker, you can use these instructions directly on a ubuntu OS (without the RUN and &&\ characters)

Hope that clarified a bit, let me know if not.

Cheers Rosa

dsilvapiedra commented 2 years ago

Hi @rosatrancoso, thanks for your answer! I was in a hurry so I "solved" the issue by installing the previous version of Mohid. I'll have in mind your comments for a future update in my code.

Cheers, Diego

iamsumesh commented 1 year ago

Hi @dsilvapiedra , Please share the version number. Is it in Linux or Windows?.

dsilvapiedra commented 1 year ago

Hi @iamsumesh , I'm using v19.10 on Linux.