MohistMC / Mohist

Minecraft Forge Hybrid server implementing the Spigot/Bukkit API, formerly known as Thermos/Cauldron/MCPC+
https://mohistmc.com
GNU General Public License v3.0
1.3k stars 217 forks source link

[1.16.5] CustomCrate keys do not work #2312

Closed Tangosucka closed 1 year ago

Tangosucka commented 2 years ago

Minecraft Version : 1.16.5

Mohist Version : mohist-1.16.5-1075-server

Operating System : Ubuntu 20.04.4 LTS

Logs : No, does not produce errors

No mods

Plugins: Only CustomCrates 5.0.3 https://www.spigotmc.org/resources/customcrates.29805/

Description of issue : Crate keys do not work. After generating a crate and a key, then trying to open crate with key it says i dont have a key. Something from mohists spigot side is changing the way the keys are identified.

To Reproduce: place a chest set it as a crate Create key for said chest try and use Key

Tested multiple configurations of crates and keys. All had same result.

Plugin developer was watching me stream and test the plugin. His observations are: The issue might revolve around the fact that CustomCrates' checks for an exact match with the item and something might be changing or adding onto the item data upon give.

He made a custom version of the plugin with the follwing change: I've created this special version to only match the display name of the item. Which should not give any other data, you can attempt to use this version but there might be bugs whilst removing the item from the player's inventory.

So with that build the key worked but was not removed from inventory after use.

MohistBOT commented 2 years ago

Hello, thanks for opening this issue!

Before continuing, please understand that Mohist is a free and open source software, made by people in their free time. Know that we are not able to give any eta about when your issue will get answered or fixed.

Our team will first check if your issue isn't duplicated. If it's the case, we will close your issue, giving your the number of the other issue so that you can follow its progress. If you are able to do it, please check that your issue isn't duplicated, this would help us a lot.

Thank you for your patience, and have a nice day (or night)!

Mgazul commented 1 year ago

Fixed