MohistMC / Mohist

Minecraft Forge Hybrid server implementing the Spigot/Bukkit API, formerly known as Thermos/Cauldron/MCPC+
https://mohistmc.com
GNU General Public License v3.0
1.28k stars 210 forks source link

[1.20.2] Add patch to spigot Advancements #3216

Closed SimonMage closed 2 months ago

SimonMage commented 2 months ago

Is your feature request related to a problem? Please describe. Please add this patch made on paper in mohist to fix Spigot advancements that are buggy in 1.20.2 -> here the patch link of paper https://github.com/PaperMC/Paper/blob/931781c220b98dde0159c9a3c8dce06c3b2b1e13/patches/server/1035-Fix-UnsafeValues-loadAdvancement.patch

Describe the solution you'd like That spigot API shows correctly advancements

Additional context You can see here the raw error when you try to use Spigot API to run advancements (the error is not directly caused by Mohist but by Spigot, I ask to add the same patch of paper on mohist.

Raw error:

[14:40:08] [Server thread/WARN]: [BetonQuest] Task #958 for BetonQuest v2.1.2 generated an exception java.lang.UnsupportedOperationException: null at com.google.common.collect.ImmutableMap.put(ImmutableMap.java:781) ~[guava-32.1.2-jre.jar:?] at org.bukkit.craftbukkit.v1_20_R2.util.CraftMagicNumbers.loadAdvancement(CraftMagicNumbers.java:264) ~[spigot-1.20.2-R0.1-SNAPSHOT.jar:3950-Spigot-2888990-d485cde] at org.betonquest.betonquest.notify.AdvancementNotifyIO$2.run(AdvancementNotifyIO.java:57) ~[?:?] at org.bukkit.craftbukkit.v1_20_R2.scheduler.CraftTask.run(CraftTask.java:82) ~[spigot-1.20.2-R0.1-SNAPSHOT.jar:3950-Spigot-2888990-d485cde] at org.bukkit.craftbukkit.v1_20_R2.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:415) ~[spigot-1.20.2-R0.1-SNAPSHOT.jar:3950-Spigot-2888990-d485cde] at net.minecraft.server.MinecraftServer.b(MinecraftServer.java:1243) ~[spigot-1.20.2-R0.1-SNAPSHOT.jar:3950-Spigot-2888990-d485cde] at net.minecraft.server.dedicated.DedicatedServer.b(DedicatedServer.java:387) ~[spigot-1.20.2-R0.1-SNAPSHOT.jar:3950-Spigot-2888990-d485cde] at net.minecraft.server.MinecraftServer.a(MinecraftServer.java:1179) ~[spigot-1.20.2-R0.1-SNAPSHOT.jar:3950-Spigot-2888990-d485cde] at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:996) ~[spigot-1.20.2-R0.1-SNAPSHOT.jar:3950-Spigot-2888990-d485cde] at net.minecraft.server.MinecraftServer.lambda$0(MinecraftServer.java:298) ~[spigot-1.20.2-R0.1-SNAPSHOT.jar:3950-Spigot-2888990-d485cde] at java.lang.Thread.run(Thread.java:842) ~[?:?]