Exlude Laravel 9 from PHP 7.4

MohmmedAshraf / laravel-translations

Laravel Translations UI package provides a user-friendly interface for managing translations in your Laravel application. It simplifies tasks such as adding, editing, deleting, and exporting translations. The package also includes a handy search feature and the ability to invite collaborators for easy translation management

MIT License

649 stars 91 forks source link

Exlude Laravel 9 from PHP 7.4 #11

Closed thinkverse closed 1 year ago

thinkverse commented 1 year ago

This PR excludes Laravel 9 from running on PHP 7.4, hopefully, that fixes your GH action. 🙂

thinkverse commented 1 year ago

@MohmmedAshraf seems to be more issues, I'll try and submit a quick PR before I go to bed to fix them. 👍

MohmmedAshraf commented 1 year ago

@thinkverse Thank you so much for your help, Sadly I am not very proficient with GitHub Actions

thinkverse commented 1 year ago

@MohmmedAshraf I think you're going to have to drop support for PHP 7.4 and only go with 8 and above. wireui/wireui has no v1 version that supports it, laravel/pint doesn't support it and your blade-flags package don't support it either. the error for the P7.4 - L8* run is pretty clear on that.

Is it OK to drop it and fix the rest? Should be just removing the PHP 7.4 part from the action and upping the require to ^8.0 instead of ^7.4.

MohmmedAshraf commented 1 year ago

@thinkverse sound good, and yeah we can drop it thank you