search

Mojang / DataFixerUpper

A set of utilities designed for incremental building, merging and optimization of data transformations.
MIT License
1.2k stars 138 forks source link

Double Stream utils #37

Closed Gegy closed 3 years ago

Gegy commented 5 years ago

This PR adds a util in DynamicOps allowing for a DoubleStream to be created from an input, and a util for a list to be created from a DoubleStream. These are direct copies of the existing variants for long and int streams.

msftclas commented 5 years ago

CLA assistant check
All CLA requirements met.

liach commented 3 years ago

I would expect mojang to add this officially during the 1.17 update. Mojang currently has a utility class that holds these potential additions.

liach commented 3 years ago

I recall this implementation is a bit different from what is in the current minecraft snapshot codebase. Be cautious when migrating.

slicedlime commented 3 years ago

Thanks for checking :)

RainWarrior commented 3 years ago

We will not be taking this PR in at this time; functionality of the double stream codec should be covered with Codec.Double.listOf() at the moment, and we will figure out the plan for primitives at a later point (#58)