search

Mojang / bedrock-samples

Samples and assets for building Minecraft: Bedrock Edition add-ons
Other
736 stars 143 forks source link

item_texture.json and terrain_texture.json was replaced instead of being merged (1.20.70) #43

Closed NSPC911 closed 2 months ago

NSPC911 commented 3 months ago

Not sure how the mistake appeared, but in the latest release, the item_texture.json and terrain_texture.json had decreased in file size drastically. Looking via GitLens (it doesn't show up on blame), I saw this for item_texture.json:

image

My suspicion is that instead of merging with the main branch, it replaced it, so the older code was gone and the new items are left. I hope this gets fixed in 1.20.80.

NSPC911 commented 3 months ago

I can attempt to open a Pull Request to fix this, but highly doubt that it will be merged

NSPC911 commented 3 months ago

Fixed it in #44

mammerla commented 2 months ago

Sorry for the delay in getting to this. I have a PR of this fix that I built out using my updated process (for preview) at https://github.com/Mojang/bedrock-samples/pull/48, with the intent to merge this in for main/preview branches soon.. LMK if you have feedback.

NSPC911 commented 2 months ago

Fixed in #48 , closed issue