Mojang / ore-ui

💎 Building blocks to construct game UIs using web tech.
https://react-facet.mojang.com/
MIT License
404 stars 19 forks source link

Feature request: Introduce DataSharedFacetValue and MethodSharedFacetValue subtypes #113

Closed xaviervia closed 7 months ago

xaviervia commented 1 year ago

Moving forward, we don't want to mix and match methods and data in shared facets. We want to think of data facets as pure data, much like Redux state, and method facet as flat lists of available API calls from the remote.

Additionally, MethodSharedFacetValues could automatically do a .bind on the methods it includes, to avoid issues with selecting individual methods from the facet and losing the this reference.

pirelenito commented 7 months ago

Closing this as we are exploring better alternative APIs for shared facets.