search

Mojang / ore-ui

💎 Building blocks to construct game UIs using web tech.
https://react-facet.mojang.com/
MIT License
404 stars 19 forks source link

Tweak hasDefinedValue typing #121

Closed pedr0fontoura closed 1 year ago

pedr0fontoura commented 1 year ago

This PR improves the typing of the hasDefinedValue helper, narrowing the facet value type if it has a defined value.

Without this change, the type of the facet value after unwrapping is a union that includes typeof NO_VALUE, which is not assignable to ReactNode.

Code_z2IIDDJfAr