Mojang / ore-ui

💎 Building blocks to construct game UIs using web tech.
https://react-facet.mojang.com/
MIT License
404 stars 19 forks source link

Fixing incoming type errors from ts 5.1.3 #130

Open Tommy-Malone-ZOS opened 11 months ago

Tommy-Malone-ZOS commented 11 months ago

After updating to TS 5.1.3 the behavior of type inference of array types looks to have changed. Previously the types of a useFacetMap for example would look like so: useFacetMap((a: number, b: string, c: boolean)=>{...},[...],[A: Facet<number>, B: Facet<string>, C: Facet<boolean]) After 5.1.3 the types look like so: useFacetMap((a: number | string | boolean, b: number |string | boolean, c: number | string | boolean)=>{...},[...],[A: Facet<number>, B: Facet<string>, C: Facet<boolean>]) The selector arguments are infered as the union of the types of all passed in Facets, rather than each arguments type corresponding to their Facet's inner type. This change fixes that issue by explicitly making the array type we were previously extending into a tuple type. This allows TS to correctly infer the arguments' types.