search

Mojang / ore-ui

💎 Building blocks to construct game UIs using web tech.
https://react-facet.mojang.com/
MIT License
409 stars 18 forks source link

Add support for onScroll event listeners #61

Closed pirelenito closed 2 years ago

pirelenito commented 2 years ago

This PR extends both @react-facet/dom-fiber and @react-facet/dom-components to add support for the onScroll events. In the past this wasn't supported by Gameface, but I've checked it recently and it now works.

pirelenito commented 2 years ago

It seems though that I was wrong in regards to support by Gameface. Although it works for events originated from the mouse wheel, it won't work when we programmatically change the scrollTop position.

So I guess for now, I'll reject this PR.

Thanks for the reviews and sorry for the mess-up 🤦‍♂️