search

Mojang / slicer

Resource pack migration tool for Minecraft 1.14
MIT License
174 stars 7 forks source link

GUI images are cut off, making them stretched in game #7

Closed SankFrinatra closed 6 months ago

SankFrinatra commented 11 months ago

I'm trying to update a texture pack I use (Clarity from SCtester from 1.20.1 to 1.20.4. I am having issues where Slicer cuts off the right part of the villager GUI image (see first image), causing it to become stretched in game (see second image). The individual sprites that Slicer is supposed to create are also completely blank images (see third image for an example). I know Slicer is otherwise working correctly as other parts of the GUI have been converted and appear correctly.

Some extra info that might be pertinent:

  1. The original villager GUI file was named villager.png and had to be renamed to villager2.png for Slicer to detect it and slice it.
  2. The original villager GUI is 512x512 pixels.

villager

in-game

experience_bar_background

VidTDM commented 10 months ago

Is this only happening to villager.png?

SankFrinatra commented 10 months ago

Indeed, only on villager.png. Everything else slices fine and well. It might help to see that this is what the original villager2.png was (I was informed by the pack author that they used an outdated format - not sure if there's something to do about this with slicer other than change it to the current format manually)

villager

lowercasebtw commented 6 months ago

It's because villager.png was a leftover remanent from pre 1.14 days, the old villager GUI & as far as I know, its new counterpart villager2.png uses a different layout so this shouldn't be changed nor fix or anything as this pack needs a newer updated image & cant use a legacy old one

lowercasebtw commented 6 months ago

Unless they specifically check for villager2.png not existsing and villager.png existsing & use some other set of slice data but that won't happen as this is a older texture & many packs nowadays (besides packs before 1.14) dont have that texture

VidTDM commented 6 months ago

When I used it I didn't have any problems

lowercasebtw commented 6 months ago

@VidTDM Probably because your pack was made for 1.14+, or didn't have a villager.png texture

SankFrinatra commented 6 months ago

Indeed, I talked with the creator of the pack and they confirmed that the pack was using the old villager GUI. Thanks for the help, everyone!

On Wed, Apr 24, 2024 at 3:32 PM lowercasebtw @.***> wrote:

@VidTDM https://github.com/VidTDM Probably because your pack was made for 1.14+, or didn't have a villager.png texture

— Reply to this email directly, view it on GitHub https://github.com/Mojang/slicer/issues/7#issuecomment-2075691063, or unsubscribe https://github.com/notifications/unsubscribe-auth/BES4DO2APCLITIMZLQSDAM3Y7ACETAVCNFSM6AAAAABAO6XM2SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZVGY4TCMBWGM . You are receiving this because you authored the thread.Message ID: @.***>

lowercasebtw commented 6 months ago

np