Mojave-Sun / mojave-sun-13

Join our Discord at: https://discord.gg/ms13 for tests, questions, or to help with development
GNU Affero General Public License v3.0
25 stars 90 forks source link

Map based jobs and related tweaks #2451

Closed Hekzder closed 11 months ago

Hekzder commented 11 months ago

About The Pull Request

Finally cracks the code of map based jobs, they specifically use the end of the path that a job has. Which in the PR that the .json job config was added in was pointed out by Rohesie as potentially causing issues down the line but it seems like it made it through regardless so here we are! Some job paths might be changed due to this, like Ranger Doctor getting a slightly different end path to not conflict with Snowcrest Doctor.

Also did most of the changes from #2426 that were global, like disabling old NCR and Town roles.

To-do:

Why It's Good For The Game

We can have Drought and MiniMammoth in the same test now!! yeah!!!!

Hekzder commented 11 months ago

This is more or less ready for review but not really a merge. I'll try to find time to test it in the next few days but another pair of eyes wouldn't hurt.

Hekzder commented 11 months ago

This is good for a final review/merge. Everything seems to be in order and we can work out any final kinks or bugs during dev test on Sun.