search

Mojave-Sun / mojave-sun-13

Join our Discord at: https://discord.gg/ms13 for tests, questions, or to help with development
GNU Affero General Public License v3.0
27 stars 87 forks source link

Examine text for gas masks is broken. #2525

Open Joel-682 opened 1 month ago

Joel-682 commented 1 month ago

Issue Summary

Round ID: 286

Testmerges:

2482

2459

Reproduction:

image

Whenever a gas mask is examined, at least by a ghost, they return no text. If it is examined again, one gets the "You examine the gas mask closer, but find nothing of interest"

Steps for reproduction:

  1. In the map MiniMammoth, observe.
  2. Go to the irradiated vault (Photo here image )
  3. Examine the gas mask above the skeleton. You won't see anything.
  4. Examine it again to get the "You examine the gas mask closer, but find nothing of interest" message
Joel-682 commented 1 month ago

So, it's not just /obj/item/clothing/mask/gas/ms13/modern, but every mask with "/obj/item/clothing/mask/gas/ms13". Masks from the base game (/obj/item/clothing/mask/gas) have their examine work. I presume this may have something to do with the traits of /obj/item/clothing/mask/gas/ms13.

Joel-682 commented 1 month ago

After playing a bit with the variables in /obj/item/clothing/mask/gas/ms13, I believe that it isn't a problem. Despite letting it inherit all the variables from /obj/item/clothing/mask/gas, the examine still doesn't work.

I love code, someone smarter than me fix this. I think the examine verb may be broken in regards to gas masks?

ProfessorPopoff commented 1 month ago

I know what's causing the issue- I cut it off and forgot about it. I'll have it fixed and filled out.