Mojave-Sun / mojave-sun

This repo is for archival purposes, please see https://github.com/Mojave-Sun/mojave-sun-13 for current development.
GNU Affero General Public License v3.0
13 stars 46 forks source link

Role Name Modularity #231

Closed TheRealScarHomie closed 3 years ago

TheRealScarHomie commented 3 years ago

About The Pull Request

Allows people to select multiple titles from a list for their job, Nurse role is now optional!

image

Ported from skyrat, prefrerably not merged until the issues and new repo come out//fixed.

(use the "dood" name on ncr trooper for testing the issue, nothing else has IDs)

Issues

Things above are beyond my expertise so if someone could help thatd be great.

Hekzder commented 3 years ago

This will be pretty neat to have for fluff. The latejoin thing isn't a super big deal, but the IDs not working is kind of a problem and should be fixed before a merge.

github-actions[bot] commented 3 years ago

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

TheRealScarHomie commented 3 years ago

into the breach you go kiddo, godspeed, may you return not shitcode

TheRealScarHomie commented 3 years ago

To conclude this needs ours or TGs jobs being unshitcoded to actually work with our stuff.