Mojave-Sun / mojave-sun

This repo is for archival purposes, please see https://github.com/Mojave-Sun/mojave-sun-13 for current development.
GNU Affero General Public License v3.0
13 stars 46 forks source link

New Gun sprites + General gun revamp #246

Closed Hekzder closed 3 years ago

Hekzder commented 3 years ago

About The Pull Request

Implements Infra's new gun sprites and also mildly revamps our guns in the process. Tentative gun tier list is here, which will eventually be actually coded in.

Why It's Good For The Game

We need guns.

Hekzder commented 3 years ago

Heavily WIP, this won't even compile currently. Sets up the inventory icon file and gets the icons set up for automatic.dm, removes some weapons we're no longer using, and adds/changes around existing weapons for new ones. This PR will eventually cover all inventory and in-hand icons for ballistic guns, as well as the full implementation and rough balancing for them. Any implementation of energy weapons will be for it's own PR after this one.

Hekzder commented 3 years ago

All ballistic guns should now have an icon and are fully implemented and roughly balanced. Next up is in-hands.

Overall this is a total increase of eight guns and a total decrease of nine guns, resulting in a net loss of one gun overall. Most of the lost guns were the handmade guns that Infra had originally sprited way back, and some of the other losses had rough replacements anyways. So all things considered this isn't a big loss, plus we had a ton of guns as is.

Hekzder commented 3 years ago

The gun tierlist doc is now updated accordingly, which will eventually be translated to code and can be found here.

Of note is that I'll probably be splitting the unique weapon spawner into T1/T2 uniques (low tier) and T3/T4 uniques (high tier), since there's a pretty huge gap between a T1 unique and a T4 unique, putting them in the same spawner is probably not the best idea, even if they should be used sparingly regardless. Once again, everything highlighted is fully coded and implemented as of this PR.

Hekzder commented 3 years ago

This includes right hand in-hands now, which was a completely horrible experience but atleast I'm half way though in-hands now.

Also includes changes to spawners that I forgot to mention, if it wasn't for people using spawners and placing guns on the map, this would actually have compiled prior to the in-hand commit.

Also thanos snapped our old gun icon sprites per Infra's request and because they're useless to us now, will be doing the same and cleaning up our in-hand folder a lot once I'm down with all of the gun in-hands.

Hekzder commented 3 years ago

All of the in-hands are done and in, just awaiting testing to make sure they actually work. This also now includes a heavy purge of our in-hands folder to get rid of the many, many unused and legacy .dmis inside to clean things up and make room for when we actually have good in-hands for future things like melee.

This 100% does not compile right now. I'll fix that part when I get around to testing all of this at some point.

Hekzder commented 3 years ago

This is ready for review/merge. It compiles, spawners work, and I tested a hefty chunk of guns and the sprites simultaneously work and look really fucking good. Everything seems to be fine from what I can tell.