search

Mojave-Sun / mojave-sun

This repo is for archival purposes, please see https://github.com/Mojave-Sun/mojave-sun-13 for current development.
GNU Affero General Public License v3.0
12 stars 44 forks source link

THE GREAT RADIO REWORK #286

Closed bardinatavern4 closed 3 years ago

bardinatavern4 commented 3 years ago

EDIT: Updated Reworks radios. Most radios can no longer broadcast, with new radios being added in tiers depending on broadcast quality. Low tier radios have poor broadcast quality and will have significant interference.

There are four tiers of radio. with tier 1 radios being unable to broadcast. Broadcast radios must be found looting or are spawned with specific roles. 1st tier: unable to broadcast but can receive just fine, both handheld and ham should be craftable once we get slapcrafting working. 2nd tier: A crappy broadcasting handheld radio. Each character has a 14% chance of being replaced by a . Should still be a relatively rare spawn. 3rd tier: A broadcast ham radio, backpack radio, or a very rare pre-war handheld radio. 7% chance of a character being replaced by a . Handheld should be an extremely rare spawn. 4th tier: A stationary high power broadcast set, usable only from a radio station. 1% chance of a character being replaced by a *.

Loot spawns will still need to be set after this, and we'll need unique sprites for the tiers of radio

The long term goals are to make it so that while receiving radios are very common, broadcasting radios are rare, and people will actually listen to talk shows or news broadcasts due to the rarity of radio broadcasts.

Updates since the beginning of the PR are the removal of crafting recipes and plans for a craftable broadcast radio.

ProfessorPopoff commented 3 years ago

Very cool. It is worth mentioning though that there are some things in this PR touching basecode, which is a big no-no if not used very sparingly. On top of that we have our own crafting system scar could probably tell you how to use.

Be sure to keep everything worked on within our mojave folder.

Post sleepy edit: There are some exceptions to this, but you'll have to go over it with Koshenko. He knows all the specifics, if you need a very small line of code edited out we could probably make an exception but it would have to be documented. Again- Go with dad on this.

mrpibb4201337 commented 3 years ago

fixed

Uh oh

bardinatavern4 commented 3 years ago

I indented like two lines improperly which is why there's a PR named "Fixed" and "tiny indentation edit". Both are good now.

Hekzder commented 3 years ago

Overall this is really neat stuff and a huge step towards getting radios where we want them to be for launch. My only qualms are that I think the crafting parts should be removed from this PR in favor of balancing and adjusting them later down the line, since they may be refactored to slap crafting or something else all together. As well as increasing the interference on the lower tier radios by a bit, like 16-20% for the T2 and 10-12% for the T3.

bardinatavern4 commented 3 years ago

changes implemented, should be good

ProfessorPopoff commented 3 years ago

Found a bit of a minor bug while messing around. Alt-Clicking the radiopack to retrieve the radio works initially, but once put up it won't ever work again. Stating: "You are already holding the radio!"

ProfessorPopoff commented 3 years ago

On another note, something that ought to be discussed is anonymity. There's a bit of remnant of my initial implementation with the Ham radio, and anonymizing your voice. Oughta remove that, at least for now until that's discussed a bit further.

bardinatavern4 commented 3 years ago

Removed recieve only ham radio and made it so that radios which can't broadcast cant have the broadcast option toggled in the UI. Only thing left is to fix some capitalization and spelling errors

Hekzder commented 3 years ago

Once whatever errors are fixed and Bard is comfortable with the state it's in, I'll review and merge. Seems like this will be good stuff.