Mojave-Sun / mojave-sun

This repo is for archival purposes, please see https://github.com/Mojave-Sun/mojave-sun-13 for current development.
GNU Affero General Public License v3.0
13 stars 46 forks source link

Map Overhaul from Riddler, part 1 #311

Closed EdwardNashton closed 3 years ago

EdwardNashton commented 3 years ago

Maaany changes. Police Station, Hotel, Library, Gym, Old Town Hall, some stores, bars etc. I attached some screenshots, but mainly of first floors. Of course, some buildings has second floors and basement, but there are "roof helpers" on it, so there's no need to attach them too. You'll understand which buildings has second floor, and which are not.

image

image

image

image

image

image

image

image

image

UPDATE 1:

image

image

image

image

UPDATE 2:

image

image

image

image

image

image

image

UPDATE 3: Fixed that.

image

UPDATE 4:

This basement.

image

ProfessorPopoff commented 3 years ago

I've taken a look at it, as per usual, All the buildings you added or changed look really cool. Unfortunately. You've got to fix a decent bit before I can merge this. For starters:

  1. Space tiles.

Believe it or not, but space tiles can actually mess up quite a bit! You can find them easily by selecting the space turf, right clicking it in the object panel, clicking 'Find Object on Map', and visiting each place by clicking on the coordinates and filling it in with the tile of your desire. Ideally, ones that'd make sense. image image Just a few examples of where the space is at. Just follow the quick instructions and you'll find them all with relative ease. Make sure there's exactly Zero

On a similar note, make sure these wood floors aren't the basetype. I probably did a bit of an oopsie when I was changing it around, I could have just made the default wood the common type- but alas, I didn't. We must all suffer when porting outdated content because of it. Fix any of these you see as well, you can find them the same way as the space tile. image

  1. Areas

Goes without any further context needed. Top right and bottom here don't have proper area coverage. image

  1. Misc stuff

Balance wise, I don't know what we're going to be doing about weapon spawn balance. All I know is that we don't really want too much static spawns, especially significant ones. You oughta do away with these, replace them with a spawner or whatnot. image

image TG armour kinda gringe. Infra is liable to kill you, and we don't have balancing on that. Probably don't use it.

image This looks kinda weird. Maybe it's just me, but the catwalks are really awkward.

image I didn't catch the one previously, but probably remove the names from these fellas. Not really any need to have them specifically named, and it'll eventually lead to object panel clogging and a bunch of different instances of these fellas getting popped down in the future.

image Trash bag man bad. Delete immediately. They're unbalanced, can be used to carry a thousand things with ease.

ProfessorPopoff commented 3 years ago

image Potentially final review.

  1. Don't use these holsters in the police station. They give traits and do weird gross stuff. TG man bad. image

  2. You have a singular out of place metal tile under the left door, here. Put planks there instead. image

  3. Weird lil forest area remained over this concrete section here. image

  4. Lack of areas given to this restaurant lower storage, on the path to the gambling den. imageL

That's all I could find. For the sake of consistency for the map, please try to localize your changes a bit more in future PRs. Not for just my mental sanity, but for the overall structure of the map. If I can't find messups, they'll stay there, and then we have to fix them individually in future PRs.

ProfessorPopoff commented 3 years ago

Fixes are all good. Disregard the first issue, because I was wrong. They are ours, but are still busted. They'll be left in and fixed down the line hopefully. Merging this. Thanks for the work. Keep it in one area next time, though.