Mojave-Sun / mojave-sun

This repo is for archival purposes, please see https://github.com/Mojave-Sun/mojave-sun-13 for current development.
GNU Affero General Public License v3.0
12 stars 45 forks source link

Going Nuclear: Powerplant and Underground Village #318

Closed EdwardNashton closed 3 years ago

EdwardNashton commented 3 years ago

Removed old bunker in a mountain. Replaced it with Powerplant (with Administration and Canteen). Improved Underground Village. Reworked some "maintenance room" in a Sewers nearby Village that I made before. Fixed a stairs.

image

image

image

image

image

UPDATE:

image

image

image

ProfessorPopoff commented 3 years ago

Very cool location. It definitely changes the map up... Considerably. But I think it isn't the worst. Nobody gave their input when I pinged literally everyone with the mapper role, so their opinions no longer matter. Anyways. With the issues that this has that will need to be fixed before merging.

Missing Z level stuff

Please ensure all mountains have either overhead mountain above them, or whatever else you think belongs up there. It just can't be sitting there without anything above it. image Notice the lack of mountains or roof on this level above the rock ridges made.

Similarly, Make sure all the walls have roof above them. This bit and the bit on the other side are lacking mountain. image

Not only is this elevator shaft mis-aligned with the one on the bottom, but you can also use openspace on the top one. Both of them wouldn't have elevator shaft base tiles on it, surely? image There's also actually an industrial elevator that TG station has. Albeit, a bit spammy right now. Though we could make our own type later on probably.

Make sure that you don't have these broken foundations over walls. They look bad. Ensure it's a clear walking space under it, please.

image

Technical issues

I already told you about this one previous, but they're a bit busted. I could maybe try to make these work in the near future, but no guarantees. In that event we'd have to remove them later on, because they're broken. Emphasis on broken. image

Apparently this is a placeholder and you've marked it as son, but apparently TG really doesn't like that and is spitting out errors. So just un-var edit it. It stands out enough that if it was a problem it could get its own MS variant with a different texture or whatnot. image image

Whoever added the tables for some reason set the icon state of the base class to be the metal table. Do NOT use those, use the metal variant. I'll be fixing this manually in the future and getting rid of the icon state. You ought to replace these all with the metal variant. image

Missing fence, here. image

Nitpicks

Could probably use some parking lines here. image

Under the impression this is supposed to be those spinning things, but it'd be better if you just didn't have them there at all. I doubt it'll get made, and if we forget about it, it'll be dumb to have to fix it later on if it makes it in at launch time. image

Weird asymmetricity here. image

Bit list. But that's about all i've got. After you fix this, you'll also have to wait a bit for my dumb self to figure out the holotable thing and get my PR through so that you can update it all and paste it into the new version. that way we're red check free and the low walls are all good. I want you to specifically wait for this so that the low walls are all good. PLUS. It seems you're actually outdated. So either way you'll have to update, and it'll be easier if you just wait until mine goes through so you only have to do it once.

ProfessorPopoff commented 3 years ago

Alright cool. The recent commit addressed a lot of the things I asked to fix, Nearly there. I apologize, I don't know if I missed this the first time, but this entire building south of the powerplant is lacking areas on the roof. image

You've also got a little stray area overhanging here on the administration building, on top of the light pole there. image

Better, that you're using the openspace in the elevator shaft. But it's still mis-aligned. Shift the bottom Z level's shaft over one tile to the left and you're good to go. image

You also ought to pop some roofs on these things. They are currently open in the top Z image

ProfessorPopoff commented 3 years ago

Alright, cool. Everything I had an issue with has been addressed. As said previously, I'm going to hold off on a second until I figure out my PR, so that we can get the green check back. and get the map updated in one fell swoop. I'll force myself to figure it out tonight.