Outdoor Effects - Githubissues

About The Pull Request

Implement weather system and replace sunlight system with "outdoor effects"

[x] :bug: Fix issue with fullscreen sunlight object appearing when no sunlight_object present on the players current turf
[x] Change sunlight object to outdoor effect object - This will hold our sunlight_object and weather effect vis_contents. Eventually this should just be a datum, with effects/vis applied to turfs. Need a nice way to handle luminosity thats compatible with lighting_objects
[x] Replace sunlight object's visual stuff with an overlay applied to the turf
[ ] Add vis_content singleton (with room to expand for simulataneous weather effects)
[ ] Add weather effect datums to apply effects
[ ] New outdoor effects subsystem to control top level visual updates and outdoor/roofed status
[ ] Remove logic from sunlight subsystem so it just controls client sunlight colours
[ ] Replace existing weather subsystem with stripped down version - should just control vis_contents and current effect
[ ] Life ticks, etc. should then hook into weather effect datum
[ ] Components where possible when everything is working
[ ] Tidy up

Outstanding TODOs + new bugs (tidy as fixed) -[ ] Hard edge against border turfs in new overlays

Rain