search

MokhaLeee / fe8u-cskillsys-kernel

Morden c-skillsystem for fireemblem8u
MIT License
9 stars 6 forks source link

'Amplificator' commit #138

Closed JesterWizard closed 3 months ago

JesterWizard commented 3 months ago

I've checked several skills with this new amplificator formula now, and I'm not getting the expected results. On Colossus it adds 200 to amplificator but this doesn't change the base damage. The same with Impale where it adds 300 and my latest addition SureStrike (which boosts damage by 1.5x) which adds 75.

MokhaLeee commented 3 months ago

It's truly that it is wrong that SID_Impale should cause damage +300% rather than 400%, now fixed

JesterWizard commented 3 months ago

This is not fixed. You've misunderstood the issue.

The calculation is not taking effect.

Here's a video displaying the issue for Colossus (which you revised to use amplificator + 200). You can see that even with the skill proccing, Eirika still does her regular damage.

https://github.com/MokhaLeee/fe8u-cskillsys-kernel/assets/164426396/9c7e7a7b-6508-442a-a947-786e50c2cae7

I believe the reason for this is because calculation damage = Div(damage * amplificatier, 100); is stuck inside InfinityEdge in BattleHit.c. After moving it outside, Colossus started applying the proper amount of damage.

image

And on the subject of the spelling of the word, we're both wrong. On googling it, it really should be amplifier.