search

MokhaLeee / fe8u-cskillsys-kernel

Morden c-skillsystem for fireemblem8u
MIT License
9 stars 6 forks source link

Skill-Blessing #144

Closed JesterWizard closed 3 months ago

JesterWizard commented 3 months ago

Guranteed to not consume weapon durability.

JesterWizard commented 3 months ago

You merged this skill, and now it seems to have been removed. I'm confused?

MokhaLeee commented 3 months ago

This PR wasn't merged. Since it was considered invalid when I reviewed it, there may have been something wrong with github. If it was to avoid breaking weapon, it was no different from #143, and its ability effect was confusing to have a 100% rate. the modification is not very logical

JesterWizard commented 3 months ago

Setting it to 100 is a holder over from my own testing of other activation skills I suppose. I guess it makes more sense to just remove that function altogether. With regards to the method not being logical, with the changes you've made to Armsthrift, the solution would be then to just make another PR based off of that?