search

MokhaLeee / fe8u-cskillsys-kernel

Morden c-skillsystem for fireemblem8u
MIT License
9 stars 6 forks source link

Skill - Lifetaker #154

Closed JesterWizard closed 3 months ago

JesterWizard commented 3 months ago

Heal 25% of the skill holder's max HP on killing an enemy.

I tried to use the HP healing animation which I think is BeginUnitHealAnim but I got an error about implicit declarations. So I had to use StartStatusHealEffect instead.

MokhaLeee commented 3 months ago

The functionality is not quite dealt particularly well. I have submit a better method on post-action heal as: https://github.com/MokhaLeee/fe8u-cskillsys-kernel/commit/a2eee758d1d94a217567fec2f2e344647f09d942

You can add skill info etc based on this commit.

JesterWizard commented 3 months ago

Almost perfect now. Just one slight issue.

When the unit's health bar displays just before the healing animation starts, It's already 25% ahead of where it should be.

So if Eirika had 9/32HP and started healing, it'll show 17/32HP on her health bar and heal up from there. But then correctly display 17/32HP afterwards.

MokhaLeee commented 3 months ago

it is recommended to repull a new PR by just modify on latest commit of main branch

MokhaLeee commented 3 months ago

It's already 25% ahead of where it should be.

I may fix it after merging your new PR