search

MokhaLeee / fe8u-cskillsys-kernel

Morden c-skillsystem for fireemblem8u
MIT License
9 stars 6 forks source link

Skills - Oath #158

Closed JesterWizard closed 3 months ago

JesterWizard commented 3 months ago

All 8 variants of the Oath skills.

+4 to the respective stat at the start of the turn if an adjacent ally is present (and removed the following turn if not).

I had to expand UNIT_STAT_DEBUFF_MAX in debuff.h from 32 to 64 to accomodate the buffs for the Oath skills.

MokhaLeee commented 3 months ago
  1. Solve the indentation issues
  2. Solve the merge conflicts
JesterWizard commented 3 months ago
  1. Solve the indentation issues
  2. Solve the merge conflicts

Done

MokhaLeee commented 3 months ago

In fact, there is a serious bug in this PR: StatDebuff index cannot expand to 32 bacause it is a bitmask of u32 and need allocate memory in SRAM. There is also a problem with the gameplay design, as with abilities in Heros, each team's buff should be triggered at the start of their respective turn. But these skill made sense though, and I decided to fix it myself